Skip to content

[query] Drop support for shared grpc/http query server ports #6695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2025
Merged

[query] Drop support for shared grpc/http query server ports #6695

merged 4 commits into from
Feb 9, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • 🛑 The grpc/http query server no longer supports serving traffic on the same port to fully migrate to OTEL's implementation of http/grpc servers. To mitigate this, use a different port for either your grpc or http server. 🛑

How was this change tested?

  • CI
  • Unit tests

Checklist

@mahadzaryab1
Drop Support For Query Service on Same Port
00bd6f7 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 added the changelog:breaking-change Change that is breaking public APIs or established behavior label Feb 8, 2025
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner February 8, 2025 19:03
@codecov Codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.99%. Comparing base (8def385) to head (c198d2d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/query/app/server.go 88.88% 0 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (89.47%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6695      +/-   ##
==========================================
- Coverage   96.00%   95.99%   -0.02%     
==========================================
  Files         363      363              
  Lines       20610    20558      -52     
==========================================
- Hits        19787    19735      -52     
  Misses        628      628              
  Partials      195      195
Flag Coverage Δ
badger_v1 9.82% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1-manual 14.79% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <ø> (ø)
cassandra-4.x-v2-manual 1.81% <ø> (ø)
cassandra-5.x-v1-manual 14.79% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <ø> (ø)
cassandra-5.x-v2-manual 1.81% <ø> (ø)
elasticsearch-6.x-v1 19.12% <ø> (ø)
elasticsearch-7.x-v1 19.20% <ø> (ø)
elasticsearch-8.x-v1 19.37% <ø> (ø)
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 10.80% <ø> (ø)
grpc_v2 7.80% <ø> (ø)
kafka-3.x-v1 10.12% <ø> (ø)
kafka-3.x-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 19.25% <ø> (ø)
opensearch-2.x-v1 19.25% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.87% <89.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yurishkuro
yurishkuro reviewed Feb 8, 2025
View reviewed changes
@mahadzaryab1
Remove cmux Dependency
3af1ba9 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@yurishkuro yurishkuro merged commit ae4fb2d into jaegertracing:main Feb 9, 2025
54 of 55 checks passed
@mahadzaryab1 mahadzaryab1 deleted the drop-same-ports branch February 9, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
changelog:breaking-change Change that is breaking public APIs or established behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[query] Drop Support For Same Host Ports
2 participants
@mahadzaryab1 @yurishkuro