Skip to content

Remove Logger parameter in adaptive/aggregator.go #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Remove Logger parameter in adaptive/aggregator.go #6586

merged 1 commit into from
Jan 21, 2025

Conversation

Nabil-Salah
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • edit HandleRootSpan and it's mocks to use aggregator parameter logger

How was this change tested?

  • make lint test

Checklist

@Nabil-Salah
feat: remove redundent logger
06dc57d 
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
@Nabil-Salah Nabil-Salah changed the title Remove Untangle Logger parameter in adaptive/aggregator.go Remove untangle Logger parameter in adaptive/aggregator.go Jan 21, 2025
@Nabil-Salah Nabil-Salah marked this pull request as ready for review January 21, 2025 20:06
@Nabil-Salah Nabil-Salah requested a review from a team as a code owner January 21, 2025 20:06
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (156a59d) to head (06dc57d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6586      +/-   ##
==========================================
+ Coverage   96.21%   96.23%   +0.01%     
==========================================
  Files         375      375              
  Lines       21389    21389              
==========================================
+ Hits        20580    20583       +3     
+ Misses        616      614       -2     
+ Partials      193      192       -1
Flag Coverage Δ
badger_v1 10.65% <ø> (ø)
badger_v2 2.78% <ø> (ø)
cassandra-4.x-v1-manual 16.61% <ø> (ø)
cassandra-4.x-v2-auto 2.71% <ø> (ø)
cassandra-4.x-v2-manual 2.71% <ø> (ø)
cassandra-5.x-v1-manual 16.61% <ø> (ø)
cassandra-5.x-v2-auto 2.71% <ø> (ø)
cassandra-5.x-v2-manual 2.71% <ø> (ø)
elasticsearch-6.x-v1 20.39% <ø> (ø)
elasticsearch-7.x-v1 20.47% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 20.62% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 2.78% <ø> (+<0.01%) ⬆️
grpc_v1 12.18% <ø> (ø)
grpc_v2 9.04% <ø> (+<0.01%) ⬆️
kafka-3.x-v1 10.34% <ø> (ø)
kafka-3.x-v2 2.78% <ø> (ø)
memory_v2 2.78% <ø> (ø)
opensearch-1.x-v1 20.52% <ø> (ø)
opensearch-2.x-v1 20.51% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 2.77% <ø> (-0.01%) ⬇️
tailsampling-processor 0.51% <ø> (ø)
unittests 95.08% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title Remove untangle Logger parameter in adaptive/aggregator.go Remove Logger parameter in adaptive/aggregator.go Jan 21, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) January 21, 2025 20:39
@yurishkuro yurishkuro merged commit d6ed101 into jaegertracing:main Jan 21, 2025
56 of 58 checks passed
@yurishkuro yurishkuro mentioned this pull request Jan 21, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/sampling changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nabil-Salah @yurishkuro