Skip to content

Move e2e scripts to scripts/e2e #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 1, 2025
Merged

Move e2e scripts to scripts/e2e #6448

merged 6 commits into from
Jan 1, 2025

Conversation

danish9039
Copy link
Contributor

Which problem is this PR solving?

part of

Description of the changes

  • organized e2e scripts

@danish9039
organized e2e scripts
4dffb86 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 requested a review from a team as a code owner December 31, 2024 02:37
@codecov Codecov
Copy link

codecov bot commented Dec 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (d0ad732) to head (3c8a0fe).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6448   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         371      371           
  Lines       21160    21160           
=======================================
  Hits        20379    20379           
  Misses        598      598           
  Partials      183      183
Flag Coverage Δ
badger_v1 10.51% <ø> (ø)
badger_v2 2.58% <ø> (ø)
cassandra-4.x-v1-manual 16.37% <ø> (ø)
cassandra-4.x-v2-auto 2.51% <ø> (ø)
cassandra-4.x-v2-manual 2.54% <ø> (+0.02%) ⬆️
cassandra-5.x-v1-manual 16.37% <ø> (ø)
cassandra-5.x-v2-auto 2.51% <ø> (ø)
cassandra-5.x-v2-manual 2.51% <ø> (-0.03%) ⬇️
elasticsearch-6.x-v1 20.08% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 20.16% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 20.33% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 2.58% <ø> (-0.10%) ⬇️
grpc_v1 12.16% <ø> (ø)
grpc_v2 8.95% <ø> (ø)
kafka-3.x-v1 10.35% <ø> (ø)
kafka-3.x-v2 2.58% <ø> (ø)
memory_v2 2.58% <ø> (ø)
opensearch-1.x-v1 20.21% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 20.22% <ø> (ø)
opensearch-2.x-v2 2.58% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.39% <ø> (ø)
unittests 95.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 31, 2024
@yurishkuro yurishkuro changed the title organized e2e scripts Move e2e scripts to scripts/e2e Dec 31, 2024
yurishkuro
yurishkuro reviewed Dec 31, 2024
View reviewed changes
.github/workflows/ci-e2e-cassandra.yml Outdated
@@ -45,7 +45,7 @@ jobs:

- name: Run cassandra integration tests
id: test-execution
run: bash scripts/cassandra-integration-test.sh ${{ matrix.version.major }} ${{ matrix.version.schema }} ${{ matrix.jaeger-version }}
run: bash scripts/e2e/cassandra-integration-test.sh ${{ matrix.version.major }} ${{ matrix.version.schema }} ${{ matrix.jaeger-version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: bash scripts/e2e/cassandra-integration-test.sh ${{ matrix.version.major }} ${{ matrix.version.schema }} ${{ matrix.jaeger-version }}
run: bash scripts/e2e/cassandra.sh ${{ matrix.version.major }} ${{ matrix.version.schema }} ${{ matrix.jaeger-version }}

please use names provided in the issue

@danish9039
rename to cassandra.sh
b20b394 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039
..
c598768 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
yurishkuro
yurishkuro reviewed Dec 31, 2024
View reviewed changes
.github/workflows/ci-e2e-elasticsearch.yml Outdated
@@ -57,7 +57,7 @@ jobs:
- uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf # v3.2.0
- name: Run ${{ matrix.version.distribution }} integration tests
id: test-execution
run: bash scripts/es-integration-test.sh ${{ matrix.version.distribution }} ${{ matrix.version.major }} ${{ matrix.version.jaeger }}
run: bash scripts/e2e/es-integration-test.sh ${{ matrix.version.distribution }} ${{ matrix.version.major }} ${{ matrix.version.jaeger }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: bash scripts/e2e/es-integration-test.sh ${{ matrix.version.distribution }} ${{ matrix.version.major }} ${{ matrix.version.jaeger }}
run: bash scripts/e2e/elasticsearch.sh ${{ matrix.version.distribution }} ${{ matrix.version.major }} ${{ matrix.version.jaeger }}

.github/workflows/ci-e2e-kafka.yml Outdated
@@ -34,7 +34,7 @@ jobs:

- name: Run kafka integration tests
id: test-execution
run: bash scripts/kafka-integration-test.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.kafka-version }}
run: bash scripts/e2e/kafka-integration-test.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.kafka-version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: bash scripts/e2e/kafka-integration-test.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.kafka-version }}
run: bash scripts/e2e/kafka.sh -j ${{ matrix.jaeger-version }} -v ${{ matrix.kafka-version }}

.github/workflows/ci-e2e-spm.yml Outdated
@@ -49,4 +49,4 @@ jobs:
uses: ./.github/actions/setup-node.js

- name: Run SPM Test
run: bash scripts/spm-integration-test.sh -b ${{ matrix.mode.binary }}
run: bash scripts/e2e/spm-integration-test.sh -b ${{ matrix.mode.binary }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: bash scripts/e2e/spm-integration-test.sh -b ${{ matrix.mode.binary }}
run: bash scripts/e2e/spm.sh -b ${{ matrix.mode.binary }}

danish9039 and others added 2 commits January 1, 2025 15:01
@danish9039
Merge branch 'main' into e2e-script
7c3c8f2
@danish9039
rename scripts
8559f22 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@yurishkuro yurishkuro enabled auto-merge (squash) January 1, 2025 19:50
@yurishkuro yurishkuro merged commit 244b759 into jaegertracing:main Jan 1, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danish9039 @yurishkuro