Skip to content

[chore] Rename spanstore to tracestore for v2 storage #6292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2024
Merged

[chore] Rename spanstore to tracestore for v2 storage #6292

merged 3 commits into from
Dec 2, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

How was this change tested?

  • CI

Checklist

@mahadzaryab1
Rename spanstore To tracestore
3170954 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Fix Callsites
1da9b3d 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1
Remove Type Aliases
e55b5c7 
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner December 2, 2024 15:22
@mahadzaryab1 mahadzaryab1 mentioned this pull request Dec 2, 2024
Merged
4 tasks
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (d1a8ece) to head (e55b5c7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6292      +/-   ##
==========================================
+ Coverage   96.18%   96.20%   +0.01%     
==========================================
  Files         356      356              
  Lines       20432    20432              
==========================================
+ Hits        19653    19656       +3     
+ Misses        589      587       -2     
+ Partials      190      189       -1
Flag Coverage Δ
badger_v1 8.90% <ø> (ø)
badger_v2 1.62% <0.00%> (ø)
cassandra-4.x-v1-manual 14.84% <ø> (ø)
cassandra-4.x-v2-auto 1.56% <0.00%> (ø)
cassandra-4.x-v2-manual 1.56% <0.00%> (ø)
cassandra-5.x-v1-manual 14.84% <ø> (ø)
cassandra-5.x-v2-auto 1.56% <0.00%> (ø)
cassandra-5.x-v2-manual 1.56% <0.00%> (ø)
elasticsearch-6.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.67% <ø> (ø)
elasticsearch-8.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v2 1.62% <0.00%> (ø)
grpc_v1 10.37% <ø> (ø)
grpc_v2 7.87% <0.00%> (ø)
kafka-v1 8.58% <ø> (ø)
kafka-v2 1.62% <0.00%> (ø)
memory_v2 1.62% <0.00%> (ø)
opensearch-1.x-v1 18.73% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.61% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.45% <0.00%> (ø)
unittests 95.11% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit e5bb9fb into jaegertracing:main Dec 2, 2024
57 checks passed
@mahadzaryab1 mahadzaryab1 deleted the storage-package-rename branch January 6, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
area/storage changelog:bugfix-or-minor-feature v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahadzaryab1 @yurishkuro