Skip to content

Allow using different container runtime #6247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2024
Merged

Allow using different container runtime #6247

merged 2 commits into from
Nov 23, 2024

Conversation

rim99
Copy link
Contributor

@rim99 rim99 commented Nov 23, 2024

Which problem is this PR solving?

People can use different container manager in protobuf makefile

make DOCKER=podman PWD=${PWD} <makefile-target>

Description of the changes

How was this change tested?

  • unix test

Checklist

@rim99
allow to define container tool to generate go files for protobuf
010e003 
Signed-off-by: rim99 <zhangxin@outlook.com>
@rim99 rim99 requested a review from a team as a code owner November 23, 2024 14:17
@rim99 rim99 requested a review from albertteoh November 23, 2024 14:17
@rim99 rim99 force-pushed the refactor-protobuf-makefile branch from c9e21a4 to 010e003 Compare November 23, 2024 14:18
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 23, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) November 23, 2024 14:42
@yurishkuro yurishkuro disabled auto-merge November 23, 2024 14:42
@yurishkuro yurishkuro changed the title allow to define container tool to generate go files for protobuf Allow using different container runtime Nov 23, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) November 23, 2024 14:43
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (7b4631c) to head (df6c4aa).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6247      +/-   ##
==========================================
+ Coverage   96.42%   96.43%   +0.01%     
==========================================
  Files         355      355              
  Lines       20149    20149              
==========================================
+ Hits        19428    19431       +3     
+ Misses        532      530       -2     
+ Partials      189      188       -1
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (ø)
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v2 1.66% <ø> (-0.01%) ⬇️
grpc_v1 9.43% <ø> (-0.01%) ⬇️
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 18.72% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (ø)
opensearch-2.x-v2 1.67% <ø> (+<0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.34% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@yurishkuro yurishkuro merged commit eba4b19 into jaegertracing:main Nov 23, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rim99 @yurishkuro