Skip to content

feat: automatically publish readme to docker hub #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 26, 2024
Merged

feat: automatically publish readme to docker hub #6118

merged 10 commits into from
Oct 26, 2024

Conversation

inosmeet
Copy link
Contributor

Which problem is this PR solving?

Fixes: #3842

Description of the changes

  • Added a shell script that publishes README.md files along with docker images to docker hub

How was this change tested?

  • Locally as well as on fork

Checklist

@inosmeet
feat: add script to automatically publish readme to docker hub
fc2bd08 
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet inosmeet requested a review from a team as a code owner October 24, 2024 16:01
@inosmeet inosmeet requested a review from albertteoh October 24, 2024 16:01
@dosubot dosubot bot added the docker Pull requests that update Docker code label Oct 24, 2024
@inosmeet
fix: lint check
176ead2 
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (f5575e2) to head (1acbedd).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6118   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         353      353           
  Lines       20112    20112           
=======================================
  Hits        19394    19394           
  Misses        533      533           
  Partials      185      185
Flag Coverage Δ
badger_v1 8.34% <ø> (ø)
badger_v2 1.69% <ø> (ø)
cassandra-4.x-v1 14.43% <ø> (ø)
cassandra-4.x-v2 1.63% <ø> (ø)
cassandra-5.x-v1 14.43% <ø> (ø)
cassandra-5.x-v2 1.63% <ø> (ø)
elasticsearch-6.x-v1 18.55% <ø> (ø)
elasticsearch-7.x-v1 18.63% <ø> (ø)
elasticsearch-8.x-v1 18.80% <ø> (ø)
elasticsearch-8.x-v2 1.68% <ø> (-0.02%) ⬇️
grpc_v1 9.37% <ø> (+<0.01%) ⬆️
grpc_v2 7.03% <ø> (ø)
kafka-v1 8.91% <ø> (ø)
kafka-v2 1.69% <ø> (ø)
memory_v2 1.69% <ø> (ø)
opensearch-1.x-v1 18.67% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 18.67% <ø> (ø)
opensearch-2.x-v2 1.68% <ø> (-0.02%) ⬇️
tailsampling-processor 0.48% <ø> (ø)
unittests 95.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inosmeet
fix: lint checks
274d927 
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet
Copy link
Contributor Author

Screenshot from 2024-10-24 21-20-58

yurishkuro
yurishkuro reviewed Oct 24, 2024
View reviewed changes
@inosmeet
feat: requested changes
e928295 
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet
test: upload-docker-readme
d979d71 
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet
fix: lint checks
9a72a2c 
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet
Copy link
Contributor Author

As for the quay.io - I wanted to get satisfactory result with the docker to get started with this PR, I'll look into it now.

Unrelated to this PR -
These recurring lint failures makes me wonder if we should have a pre-commit configured for the repo?
what do you think? @yurishkuro

@inosmeet inosmeet requested a review from yurishkuro October 25, 2024 05:10
@inosmeet
feat: add support for quay
dbb20bc 
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet
Copy link
Contributor Author

for quay.io:
Screenshot from 2024-10-25 14-29-09

yurishkuro
yurishkuro reviewed Oct 25, 2024
View reviewed changes
@inosmeet
feat: requested changes
d6b47b3 
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@inosmeet inosmeet requested a review from yurishkuro October 25, 2024 14:42
@inosmeet
Copy link
Contributor Author

CIT OpenSearch / opoensearch 2.x v2 passes on a retry

yurishkuro
yurishkuro reviewed Oct 26, 2024
View reviewed changes
yurishkuro
yurishkuro reviewed Oct 26, 2024
View reviewed changes
yurishkuro
yurishkuro reviewed Oct 26, 2024
View reviewed changes
yurishkuro
yurishkuro reviewed Oct 26, 2024
View reviewed changes
@yurishkuro
Apply suggestions from code review
a7c535a 
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@yurishkuro yurishkuro changed the title feat: add script to automatically publish readme to docker hub feat: automatically publish readme to docker hub Oct 26, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) October 26, 2024 01:06
@yurishkuro yurishkuro merged commit 85d558d into jaegertracing:main Oct 26, 2024
50 checks passed
yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
@yurishkuro
Revert "feat: automatically publish readme to docker hub (jaegertraci…
2d2d902 
…ng#6118)"

This reverts commit 85d558d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Publish description and readme to Docker Hub
2 participants
@inosmeet @yurishkuro