Remove jaeger-agent from distributions #6081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2193982 to
23eb88c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6081 +/- ##
==========================================
+ Coverage 96.92% 96.93% +0.01%
==========================================
Files 351 351
Lines 16675 16675
==========================================
+ Hits 16162 16164 +2
+ Misses 329 328 -1
+ Partials 184 183 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2 tasks
Signed-off-by: Yuri Shkuro <github@ysh.us>
1af89f1 to
2832689
Compare
yurishkuro
commented
Oct 14, 2024
11 tasks
mahadzaryab1
approved these changes
Oct 15, 2024
| var ( | ||
| queryAddr = fmt.Sprintf("http://%s:%d", host, ports.QueryHTTP) | ||
| samplingAddr = fmt.Sprintf("http://%s:%d", host, ports.CollectorHTTP) | ||
| healthAddr = fmt.Sprintf("http://%s:%d/status", host, ports.CollectorV2HealthChecks) |
There was a problem hiding this comment.
just a question for my own understanding: why is this the port here being called CollectorV2HealthChecks when it is being used in v1 as well?
There was a problem hiding this comment.
it's not being used with v1:
func healthCheckV2(t *testing.T) {
if os.Getenv("HEALTHCHECK_V2") == "false" {
t.Skip("Skipping health check for V1 Binary")
}
chahatsagarmain
pushed a commit
to chahatsagarmain/jaeger
that referenced
this pull request
Oct 23, 2024
## Which problem is this PR solving? - Part of jaegertracing#4739 ## Description of the changes - Remove jaeger-agent from binary and Docker distributions - Move agent's port mappings into `cmd/agent/app/ports.go` to clean up the main ports ## Dependencies - Need to refactor crossdock to not rely on agent ## How was this change tested? - CI ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added a commit
to yurishkuro/jaeger
that referenced
this pull request
Nov 2, 2024
This reverts commit ac6f78b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
cmd/agent/app/ports.goto clean up the main portsDependencies
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test