Update Node.js GitHub action to use npm lockfile, switch to latest Jaeger UI #6074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eger UI Required for: jaegertracing#2462 Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6074 +/- ##
==========================================
- Coverage 96.94% 96.93% -0.02%
==========================================
Files 352 352
Lines 16717 16717
==========================================
- Hits 16206 16204 -2
- Misses 328 329 +1
- Partials 183 184 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
yurishkuro
approved these changes
Oct 11, 2024
|
Let's hold off this PR until jaegertracing/jaeger-ui#2478 is merged. |
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
auto-merge was automatically disabled
October 14, 2024 16:06
Head branch was pushed to by a user without write access
|
Thanks for re-triggering the GitHub actions, the tests pass now (before I've seen docker rate limits, and before that a Node.js version mismatch in the hotrod workflow which I've fixed). |
chahatsagarmain
pushed a commit
to chahatsagarmain/jaeger
that referenced
this pull request
Oct 23, 2024
yurishkuro
added a commit
to yurishkuro/jaeger
that referenced
this pull request
Nov 2, 2024
…atest Jaeger UI (jaegertracing#6074)" This reverts commit 77939d4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test