Skip to content

Enable revive linter #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2024
Merged

Enable revive linter #5505

merged 1 commit into from
Jun 2, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 2, 2024 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • add revive to the main list of linters
  • disable some of its rules which are currently breaking for future clean-up
  • clean-up a few places what had low number of breaks

How was this change tested?

  • make lint

@yurishkuro
Enable revive linter
be663cc 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner June 2, 2024 03:22
@yurishkuro yurishkuro requested a review from jkowall June 2, 2024 03:22
@yurishkuro yurishkuro mentioned this pull request Jun 2, 2024
Closed
@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Jun 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (ca50f53) to head (be663cc).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5505      +/-   ##
==========================================
- Coverage   96.19%   96.18%   -0.02%     
==========================================
  Files         327      327              
  Lines       16012    16012              
==========================================
- Hits        15403    15401       -2     
- Misses        435      436       +1     
- Partials      174      175       +1
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <0.00%> (ø)
cassandra-3.x-v1 16.43% <ø> (ø)
cassandra-3.x-v2 1.85% <0.00%> (ø)
cassandra-4.x-v1 16.43% <ø> (ø)
cassandra-4.x-v2 1.85% <0.00%> (ø)
elasticsearch-7-v1 18.88% <ø> (-0.02%) ⬇️
elasticsearch-8-v1 19.08% <ø> (ø)
elasticsearch-8-v2 19.07% <ø> (-0.02%) ⬇️
grpc_v1 9.47% <ø> (-0.02%) ⬇️
grpc_v2 7.53% <0.00%> (ø)
kafka 9.78% <ø> (ø)
opensearch-1-v1 18.94% <ø> (ø)
opensearch-2-v1 18.94% <ø> (+0.01%) ⬆️
opensearch-2-v2 18.94% <ø> (+0.01%) ⬆️
unittests 93.87% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit b38d2f9 into jaegertracing:main Jun 2, 2024
@yurishkuro yurishkuro deleted the add-revive-linter branch June 2, 2024 15:31
@yurishkuro yurishkuro mentioned this pull request Jun 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

1 more reviewer

@pushkarm029 pushkarm029 pushkarm029 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurishkuro @pushkarm029