Add Purge method for ES/OS
#5407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5407 +/- ##
==========================================
+ Coverage 95.19% 95.21% +0.01%
==========================================
Files 346 346
Lines 16908 16925 +17
==========================================
+ Hits 16096 16115 +19
+ Misses 611 609 -2
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
adding unit tests EDIT : I dont think we need it. |
yurishkuro
reviewed
May 2, 2024
yurishkuro
reviewed
May 2, 2024
yurishkuro
reviewed
May 2, 2024
yurishkuro
reviewed
May 2, 2024
yurishkuro
reviewed
May 2, 2024
yurishkuro
reviewed
May 2, 2024
yurishkuro
reviewed
May 2, 2024
yurishkuro
reviewed
May 2, 2024
yurishkuro
approved these changes
May 2, 2024
This was referenced May 3, 2024
pushkarm029
added a commit
to pushkarm029/jaeger
that referenced
this pull request
May 4, 2024
## Which problem is this PR solving? - part of jaegertracing#5345 ## Description of the changes - Added Purge method for ES/OS - optimized integration test for es/os storage ## How was this change tested? - `STORAGE=elasticsearch make storage-integration-test` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
STORAGE=elasticsearch make storage-integration-testChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test