Skip to content

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • The cmd.RunE interceptor is changed to provide an internal value to the --config flag if no flag was present on cmd line
  • This avoids creating the collector manually, once we set the flag we always delegate back to official OTel code
  • The value for the config is embedded in the binary and passed using yaml:..., which is one of the official config providers in OTel

How was this change tested?

  • Ran all-in-one manually

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner October 21, 2023 01:58
@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit e1e1564 into jaegertracing:main Oct 21, 2023
@yurishkuro yurishkuro deleted the jv2-aio branch October 21, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:exprimental Change to an experimental part of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant