Add demo tracing app #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ideepika
pushed a commit
to ideepika/jaeger
that referenced
this pull request
Oct 22, 2017
Closed
4 tasks
yurishkuro
pushed a commit
that referenced
this pull request
Jul 26, 2025
## Which problem is this PR solving? - Resolves part of #7261 ## Description of the changes - Working on: `examples/hotrod/pkg/pool/pool.go` (`Pool.Stop` Method) - Files identified by deadcode tool: `examples/hotrod/pkg/pool/pool.go`: - `Pool.Stop` method unreachable - When introduced: PR #40 - When fixed: PR #1454 - current state: Pool.Stop() method is never called anywhere in the codebase. Only Pool.New() and Pool.Execute() are used in production - Files to modify: `examples/hotrod/pkg/pool/pool.go` - remove Stop() method ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.