Fix HotRod job pool termination (#1453) #1454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1454 +/- ##
=========================================
+ Coverage 99.81% 100% +0.18%
=========================================
Files 179 165 -14
Lines 8554 7510 -1044
=========================================
- Hits 8538 7510 -1028
+ Misses 9 0 -9
+ Partials 7 0 -7
Continue to review full report at Codecov.
|
yurishkuro
requested changes
Apr 3, 2019
| @@ -49,5 +49,7 @@ func (p *Pool) Execute(job func()) { | |||
|
|
|||
| // Stop halts all the workers | |||
| func (p *Pool) Stop() { | |||
| p.stop <- struct{}{} | |||
| if p.stop != nil { | |||
There was a problem hiding this comment.
why is the nil check necessary?
There was a problem hiding this comment.
@yurishkuro sorry for the late reply,
IMHO, this is a bug. Assuming you have more than 1 worker, calling stop only stops 1 of the workers and not all, while as closing the chan stops all the workers. Please let me know if you still want me to rename the PR.
yurishkuro
approved these changes
Apr 17, 2019
Closed
4 tasks
yurishkuro
pushed a commit
that referenced
this pull request
Jul 26, 2025
## Which problem is this PR solving? - Resolves part of #7261 ## Description of the changes - Working on: `examples/hotrod/pkg/pool/pool.go` (`Pool.Stop` Method) - Files identified by deadcode tool: `examples/hotrod/pkg/pool/pool.go`: - `Pool.Stop` method unreachable - When introduced: PR #40 - When fixed: PR #1454 - current state: Pool.Stop() method is never called anywhere in the codebase. Only Pool.New() and Pool.Execute() are used in production - Files to modify: `examples/hotrod/pkg/pool/pool.go` - remove Stop() method ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes