-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Labels
buggood first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implementstorage/kafka
Description
What happened?
Using v1.66.0
The PR 6270, change the way to load TLS on kafka.
Previously with kafka.[producer,consumer].authentication=plaintext if kafka.[producer,consumer].tls.enabled, || config.TLS.Enabled
was loading setTLSConfiguration
.
The new code only loads TLS when authentication=tls, failing the connection with other authentication (plaintext/kerberos) + TLS (does not upgrade to TLS during authentication).
Basically it has become impossible to configure SASL-SSL with PLAIN.
Steps to reproduce
- Run jaeger-collector/jaeger-ingester with kafka + TLS producer/consumer enabled and authentification = plaintext (kerberos is probably also impacted).
- Crash to connect to remote kafka.
- See Relevant log output
Expected behavior
It should work as before.
Relevant log output
Feb 17 15:47:19 infra-2.local docker-compose[3961324]: jaeger-collector_1 | {"level":"fatal","ts":1739807239.7673259,"caller":"collector/main.go:75","msg":"Failed to init storage factory","error":"kafka: client has run out of available brokers to talk to: 5 errors occurred:\n\t* EOF\n\t* unexpected EOF\n\t* dial tcp: address broker-004.local:9091broker-005.local:9091: too many colons in address\n\t* unexpected EOF\n\t* unexpected EOF\n","stacktrace":"main.main.func1\n\tgithub.com/jaegertracing/jaeger/cmd/collector/main.go:75\ngithub.com/spf13/cobra.(*Command).execute\n\tgithub.com/spf13/cobra@v1.8.1/command.go:985\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tgithub.com/spf13/cobra@v1.8.1/command.go:1117\ngithub.com/spf13/cobra.(*Command).Execute\n\tgithub.com/spf13/cobra@v1.8.1/command.go:1041\nmain.main\n\tgithub.com/jaegertracing/jaeger/cmd/collector/main.go:152\nruntime.main\n\truntime/proc.go:272"}
Feb 17 15:49:08 infra-2.local docker-compose[3964107]: jaeger-ingester_1 | {"level":"fatal","ts":1739807348.9089887,"caller":"ingester/main.go:72","msg":"Unable to create consumer","error":"kafka: client has run out of available brokers to talk to: 5 errors occurred:\n\t* unexpected EOF\n\t* unexpected EOF\n\t* EOF\n\t* dial tcp: address broker-004.local:9091broker-005.local:9091: too many colons in address\n\t* unexpected EOF\n","stacktrace":"main.main.func1\n\tgithub.com/jaegertracing/jaeger/cmd/ingester/main.go:72\ngithub.com/spf13/cobra.(*Command).execute\n\tgithub.com/spf13/cobra@v1.8.1/command.go:985\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tgithub.com/spf13/cobra@v1.8.1/command.go:1117\ngithub.com/spf13/cobra.(*Command).Execute\n\tgithub.com/spf13/cobra@v1.8.1/command.go:1041\nmain.main\n\tgithub.com/jaegertracing/jaeger/cmd/ingester/main.go:108\nruntime.main\n\truntime/proc.go:272"}
Screenshot
No response
Additional context
No response
Jaeger backend version
v1.66.0
SDK
No response
Pipeline
No response
Stogage backend
No response
Operating system
No response
Deployment model
No response
Deployment configs
Metadata
Metadata
Assignees
Labels
buggood first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implementstorage/kafka