-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Closed
Labels
changelog:breaking-changeChange that is breaking public APIs or established behaviorChange that is breaking public APIs or established behaviorgood first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implement
Description
We support two forms of plugins for external storage (https://github.com/jaegertracing/jaeger/tree/main/plugin/storage/grpc)
- a sidecar model using hashicorp/go-plugin library
- a remote storage implementing gRPC Remote Storage API
Even though the recent Hashicorp license changes (cncf/foundation#617) may not affect the go-plugin
library, the dual plugin model creates unnecessary complication and requires extra code to maintain. And while I did not try it myself, I expect that the sidecar model can be reproduced relatively easily by the users themselves, e.g. by running the existing plugin binaries as a sidecar using their own orchestration mechanisms.
The proposal has been accepted. Roadmap:
- Give a 6-month grace period for existing users or sidecar plugins to switch to remote gRPC model
- Remove the sidecar code & examples
- Clean up the code for gRPC Remote Storage
- Remove github.com/hashicorp/go-plugin dependency #5446
- Update documentation
- Completely remove "grpc-plugin" as storage type #5741
jkowall, tanayvaswani, pavolloffay, afzal442 and aaronjheng
Metadata
Metadata
Assignees
Labels
changelog:breaking-changeChange that is breaking public APIs or established behaviorChange that is breaking public APIs or established behaviorgood first issueGood for beginnersGood for beginnershelp wantedFeatures that maintainers are willing to accept but do not have cycles to implementFeatures that maintainers are willing to accept but do not have cycles to implement