Fix MCP server download issues #18
Merged
+165
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the 404 errors when downloading the MCP server binaries by: 1. Updating the getDownloadUrl function in install.ts to use the correct naming conventions: - Windows: mcp-server-windows.exe - macOS arm64: mcp-server-macos-arm64 - macOS x64: mcp-server-macos-x64 - Linux: mcp-server-linux (no architecture in filename) 2. Making the download URL dynamic in bun.config.ts by reading the version from package.json 3. Adding test scripts to verify download functionality 4. Adding detailed documentation in DOWNLOAD_FIXES.md 5. Improving TypeScript type definitions for development environments Resolves the 404 error issue when attempting to download the MCP server from the plugin.
✅ Deploy Preview for superb-starlight-b5acb5 canceled.
|
|
Wow @billwestrup, great PR! It certainly looks like this will fix the 404 issue on Linux. Approved. |
|
Thanks for the feedback, this was my first PR. I used Windsurf to find bug
and fix it.
------------------------------
Hi Jack,
Thanks for the feedback on my first PR! I was able to identify and fix the
bug using Windsurf.
Thanks,
Bill
…On Sun, Mar 23, 2025 at 5:39 PM Jack Steam ***@***.***> wrote:
Wow @billwestrup <https://github.com/billwestrup>, great PR! It certainly
looks like this will fix the 404 issue on Linux. Approved.
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIGHXNKBELQ257JFUSVF2IL2V4Z2DAVCNFSM6AAAAABZQSTVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBWGUYTQMZUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: jacksteamdev]*jacksteamdev* left a comment
(jacksteamdev/obsidian-mcp-tools#18)
<#18 (comment)>
Wow @billwestrup <https://github.com/billwestrup>, great PR! It certainly
looks like this will fix the 404 issue on Linux. Approved.
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIGHXNKBELQ257JFUSVF2IL2V4Z2DAVCNFSM6AAAAABZQSTVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBWGUYTQMZUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the 404 errors when downloading the MCP server binaries by:
Updating the getDownloadUrl function in install.ts to use the correct naming conventions:
Making the download URL dynamic in bun.config.ts by reading the version from package.json
Adding test scripts to verify download functionality
Adding detailed documentation in DOWNLOAD_FIXES.md
Improving TypeScript type definitions for development environments
Resolves the 404 error issue when attempting to download the MCP server from the plugin.