Obsidian team review changes #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in response to Obsidian team review
This PR addresses feedback from the Obsidian team around naming conventions, platform compatibility, and UI text styling:
Naming changes
Platform compatibility improvements
basePath
property onDataAdapter
interfaceinstanceof FileSystemAdapter
before accessing filesystem methodsgetFileSystemAdapter
to safely handle platform checksUI text styling
Other improvements
These changes improve platform compatibility, follow Obsidian's guidelines more closely, and make the plugin more robust across different environments.