Skip to content

Conversation

jacksteamdev
Copy link
Owner

@jacksteamdev jacksteamdev commented Jan 25, 2025

Changes in response to Obsidian team review

This PR addresses feedback from the Obsidian team around naming conventions, platform compatibility, and UI text styling:

Naming changes

  • Renamed "Obsidian MCP Tools" to "MCP Tools for Obsidian" throughout the project to comply with first-party product naming conventions
  • Updated package names and documentation to reflect the new naming
  • Updated component titles and UI text to use the new name

Platform compatibility improvements

  • Removed unsafe assumption of basePath property on DataAdapter interface
  • Added proper type checking using instanceof FileSystemAdapter before accessing filesystem methods
  • Created utility function getFileSystemAdapter to safely handle platform checks
  • Added error handling for unsupported platforms
  • Updated installation and uninstallation logic to use proper filesystem access methods

UI text styling

  • Updated all UI text to use sentence case following Obsidian guidelines
  • Fixed casing in button text and status messages:
    • "Install Server" → "Install server"
    • "Installing MCP Server..." → "Installing MCP server..."
    • "Uninstalling MCP Server..." → "Uninstalling MCP server..."

Other improvements

  • Added better error handling around filesystem operations
  • Fixed config file path handling to be more platform-agnostic
  • Updated build configuration to better handle production vs development environments

These changes improve platform compatibility, follow Obsidian's guidelines more closely, and make the plugin more robust across different environments.

Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for superb-starlight-b5acb5 canceled.

Name Link
🔨 Latest commit 4ead6e2
🔍 Latest deploy log https://app.netlify.com/sites/superb-starlight-b5acb5/deploys/679566526e35ef00089564f4

@jacksteamdev jacksteamdev merged commit 35000ef into main Jan 25, 2025
@jacksteamdev jacksteamdev deleted the fix--apply-obsidian-review-changes branch January 25, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant