Upgrade ECJ from 3.12.1 to 3.32.0 #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchof
reviewed
Feb 21, 2023
marchof
reviewed
Feb 21, 2023
3e5c0e0 to
71096c4
Compare
marchof
reviewed
Feb 24, 2023
| @@ -267,18 +267,22 @@ <h2>Compilation and testing with different JDKs</h2> | |||
| <li><code>mvn clean verify -Djdk.version=6 -Dbytecode.version=6</code></li> | |||
| <li><code>mvn clean verify -Djdk.version=7 -Dbytecode.version=7</code></li> | |||
| <li><code>mvn clean verify -Djdk.version=8 -Dbytecode.version=8</code></li> | |||
| <li><code>mvn clean verify -Djdk.version=8 -Dbytecode.version=8 -Decj</code></li> | |||
| <li><code>mvn clean verify -Djdk.version=8 -Dbytecode.version=8</code></li> | |||
There was a problem hiding this comment.
I think the whole line should be deleted now.
There was a problem hiding this comment.
Indeed, don't know why missed this 😆 done
marchof
reviewed
Feb 24, 2023
| <li><code>mvn clean verify -Djdk.version=9 -Dbytecode.version=9</code></li> | ||
| <li><code>mvn clean verify -Djdk.version=10 -Dbytecode.version=10</code></li> | ||
| <li><code>mvn clean verify -Djdk.version=11 -Dbytecode.version=11</code></li> | ||
| <li><code>mvn clean verify -Djdk.version=11 -Dbytecode.version=11 -Decj</code></li> |
There was a problem hiding this comment.
While Java 11 should now be listed twice: With and without -Decj
marchof
requested changes
Feb 24, 2023
Version `4.6.1` of previously used artifact `org.eclipse.jdt:ecj` was actually version of Eclipse IDE. This version supports source/target from Java 1.1 up to 19. Also note that starting from version `3.27.0` ECJ requires Java 11 for execution.
marchof
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
4.6.1of previously used artifactorg.eclipse.jdt:ecjwas actually version of Eclipse IDE.This version supports source/target from Java 1.1 up to 19.
Also note that starting from version
3.27.0ECJ requires Java 11 for execution.