Skip to content

Update filter for unsafe cast operator for Kotlin 1.4 #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 5, 2021

Conversation

Godin
Copy link
Member

@Godin Godin commented Dec 18, 2020

Fixes #1134

@Godin Godin marked this pull request as ready for review January 5, 2021 14:54
@Godin
Copy link
Member Author

Godin commented Jan 5, 2021

@marchof could you please review?

Since for implementation of unsafe cast Kotlin compiler now uses generic NullPointerException I hardened filter to not run on non-Kotlin classes and to hopefully remove possibility of filtering hand-written code, i.e. so far can't imagine hand-written Kotlin code that compiles into dup instruction followed by null-check.

Merge of this PR will also allow further update of Kotlin to 1.4.20 in org.jacoco.core.test.validation.kotlin during resolution of #1126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

Kotlin 1.4 uses NullPoinerException instead of TypeCastException, KotlinUnsafeCastOperatorFilter no more filters 'unsafe' branch
3 participants