Skip to content

Make StringSwitchEcjFilter consistent with KotlinWhenStringFilter #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2021
Merged

Make StringSwitchEcjFilter consistent with KotlinWhenStringFilter #1099

merged 2 commits into from
Apr 5, 2021

Conversation

T45K
Copy link
Contributor

@T45K T45K commented Oct 2, 2020

In #942, if statement was added before variable replacements declaration (here), but in #944, similar modification of #942, if statement was added after replacements declaration (here).
This PR moved if statement in StringSwitchEcjFilter#match for consistency and improving performance (unused variable replacement will not be declared).

@Godin Godin self-requested a review October 15, 2020 09:04
@Godin Godin changed the title Make consistent Make StringSwitchEcjFilter consistent with KotlinWhenStringFilter Apr 5, 2021
@Godin Godin added this to the 0.8.7 milestone Apr 5, 2021
@Godin Godin merged commit 9a88237 into jacoco:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Godin Godin Godin approved these changes

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
None yet
Projects
Current work items
Archived in project
Milestone
0.8.7
Development

Successfully merging this pull request may close these issues.
3 participants
@T45K @Godin @marchof