Skip to content

Remove unnecessary about.html files #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Conversation

marchof
Copy link
Member

@marchof marchof commented Sep 2, 2019

These modules are not distributed.

@marchof marchof added this to the 0.8.5 milestone Sep 2, 2019
@marchof marchof requested a review from Godin September 2, 2019 16:00
Copy link
Member

@Godin Godin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchof seems that you forgot org.jacoco.core.test/about.html and org.jacoco.cli.test/about.html

@marchof marchof force-pushed the remove-unused-about-html branch from 7abf77d to e2d10e7 Compare September 3, 2019 04:43
@marchof
Copy link
Member Author

marchof commented Sep 3, 2019

@Godin Ups, removed now.

@marchof marchof force-pushed the remove-unused-about-html branch from e2d10e7 to 80a1242 Compare September 3, 2019 04:59
@Godin
Copy link
Member

Godin commented Sep 3, 2019

@marchof sorry that I noticed this only after first review - we also don't distribute org.jacoco.examples , only sources from it are unpacked into zip distribution, so maybe also remove org.jacoco.examples/about.html? WDYT?

These modules are not distributed.
@marchof marchof force-pushed the remove-unused-about-html branch from 80a1242 to 66c4e4f Compare September 3, 2019 19:13
@marchof
Copy link
Member Author

marchof commented Sep 3, 2019

@Godin Sure, removed now. I wonder whether it is possible to automatically check that every published artifact contains a about.html file?

@Godin Godin merged commit 70ea136 into master Sep 3, 2019
@Godin Godin deleted the remove-unused-about-html branch September 3, 2019 21:55
@jacoco jacoco locked as resolved and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants