-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix substitution in org.jacoco.ant/about.html
#926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for picking this up quickly! Here is something strange: When I run the build locally, replacement does not work at all (neither in *.html or in *.properties) and finally Ant tests fail:
My local environment was:
Any proposal what I can do on my side to investigate? |
In line 94 of |
2eb8bb4
to
7e14975
Compare
Fixed and double-checked all remaining occurrences of regex
This is very weird - I just checked with
? |
7e14975
to
4283cc8
Compare
@Godin Ok, I found the cause: When I build in Do you wan't to investigate (and fix) this or do we require workspace root as working directory for build? |
@marchof weird again, because
works for me. So my best wild guess remains the same - are you using Eclipse Maven Launcher or command line? |
Looks like this some local problem on my side only. |
@Godin Ok, looks like running Eclipse kicks-in and copies original resources to target. |
4283cc8
to
b989c4f
Compare
`org.jacoco.ant` module uses `maven-bundle-plugin` which requires usage of `${...}` pattern, so for consistency also use it everywhere.
b989c4f
to
00ba132
Compare
Fixes #924