Add current module to aggregated report #680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only coverage data from dependent modules participated in aggregated report. After this change current module data is added as well. In some cases this will simplify multi-module project configuration. Dedicated module for aggregated report will not be required. There will be possibility to generate aggregated report for the module depending on all other (if there is such).
|
@gslowikowski This is included unconditionally, right? If the aggregate module contains code this will become part of the report. I assume we make other users unhappy with this change. So probably we need at least a way to make this behavior configurable. |
This was referenced Jan 8, 2019
|
This was not accepted because #680 (comment) from @marchof was ignored. I'm closing this as duplicate of #812 , which hopefully contains clean description of why this as well as almost identical #430 were not accepted. |
This was referenced Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only coverage data from dependent modules participated in aggregated report. After this change current module data is added as well.
In some cases this will simplify multi-module project configuration. Dedicated module for aggregated report will not be required. There will be possibility to generate aggregated report for the module depending on all other (if there is such).