Log more interesting information #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From experience, browser sometimes transmit query strings and fragments in the reports. In order to protect sensitive data, this might be harmful.
Allow logging multiple dimensions of meta information in the report URL.
|
thanks for the PR @thriqon, this looks great. if you can address the failing CI checks, i'm happy to merge this in given it's backwards compatible. |
net/netip is not present in 1.17
Package net/netip is missing in default go setup.
|
I've updated Go at three places, since |
|
i'm happy supporting 1.18+ (latest minus 2) so using that in CI seems reasonable to me 👍 |
|
Removed usage of |
|
LGTM to me @thriqon, thanks for your effort getting this one over the line! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our use case, we want do log additional information about a CSP report.
This change should be backwards-compatible:
pathfield is new, but in structured logging and in JSON additional fields should not be a problem.