Add flag to change healthcheck url #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @kdauzickas! Would you be able to update your Pull Request description with a little context about this change? On the surface, it looks fine however I'd like to ensure I'm fully understanding your issue and the intended fix. With this change, we'll also need to look at updating the README command line options section as well to keep these documented. |
|
Appreciate the update here @kdauzickas and apologies on the delay. As you force pushed this, I didn't get a notification the change was ready. This looks fine to me! Thanks again 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Health check urls aren't really standardized - many use healthz but just as many use completely custom endpoints.
Having a command line option to change this url adds some flexibility when deploying this application without provided helm chart.