Skip to content

Conversation

akemrir
Copy link
Contributor

@akemrir akemrir commented Aug 1, 2023

Please do the code review.
It works the same way as the other suggestions.

But I need to work on tests.

@akemrir akemrir marked this pull request as draft August 1, 2023 19:37
@akemrir
Copy link
Contributor Author

akemrir commented Aug 1, 2023

Ok. All tests passes. Let me know what you think about them.

@akemrir akemrir marked this pull request as ready for review August 1, 2023 19:44
@codecov-commenter
Copy link

Codecov Report

Merging #15 (16650ba) into main (fe47d90) will increase coverage by 0.15%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   85.96%   86.12%   +0.15%     
==========================================
  Files          11       11              
  Lines        1824     1845      +21     
==========================================
+ Hits         1568     1589      +21     
  Misses        179      179              
  Partials       77       77              
Files Changed Coverage Δ
completion.go 90.80% <100.00%> (+0.75%) ⬆️
completion_usage.go 90.90% <100.00%> (+0.90%) ⬆️

@jxskiss
Copy link
Owner

jxskiss commented Aug 1, 2023

Looks good to me, thank you for the contribution.
I am going to merge it.

@jxskiss jxskiss merged commit 69ae6e5 into jxskiss:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants