This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Handle kernel restarts #276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b90f0b8 to
59b4500
Compare
59b4500 to
28d99df
Compare
jtpio
commented
Dec 12, 2019
src/index.ts
Outdated
| debug.session.client = client; | ||
| debug.session = new DebugSession(); | ||
| } | ||
| debug.session.client = client; |
There was a problem hiding this comment.
This follows the same approach as when we set the session on the service.
It removes the possibility to provide a client to the constructor, so the client can only be set via the setter.
jtpio
commented
Dec 12, 2019
src/service.ts
Outdated
| return; | ||
| } | ||
| // TODO: listen to status changes only if the client / kernel | ||
| // has support for debugging |
There was a problem hiding this comment.
This could be done at the plugin level, re-using some of the logic from #239
d81c47a to
e0b0d71
Compare
e0b0d71 to
27c0061
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76.
Restarting the kernel will also restart the debugger. For now the breakpoints are not saved and restored.
This needs to take into account the state of the toggle button from #239 later on.