Skip to content

Increased the performance of GCP segment #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

caleb-artifact
Copy link
Contributor

Reduced the amount of time it takes to get the Google Cloud Project by attempting to read config files directly, and falling back to gcloud only if we experience an error.

Reduced the amount of time it takes to get the Google Cloud Project
by attempting to read config files directly, and falling back to gcloud
only if we experience an error.
@justjanne
Copy link
Owner

I’ll further look into it this weekend

Co-authored-by: Janne Mareike Koschinski <janne@kuschku.de>
@caleb-artifact
Copy link
Contributor Author

I updated the commit with you suggestion, wondering if you have had time to review the change?

@justjanne justjanne merged commit 7b8a17e into justjanne:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants