Added some missing variables #4356
Conversation
Would you mind sharing your use case? |
I was playing with this application today and wanted to make a more sophisticated script that lists and kills applications in the system. The other variables (FZF * LABEL) I exported because I thought it was missing, since some of them were already being exported and others did not. I couldn't think of any problem exporting more variables, so I did it! If you think this is a bad idea, I ask you at least consider the "FZF_POINTER" variable! Script: https://gist.github.com/Dominiquini/783863e0024f72275246b12056881e87 Thanks. |
|
I was a little concerned exporting too many variables would make process execution a little heavier. But I don't think the difference will be ever noticeable. Not sure why the test is failing on CI as it passes locally. Let me look into it. |
|
In my opinion, any attribute that is possible to change during execution using actions (change-, transform-), must have some way to read during execution! Thank you for considering this suggestion and looking at it! |
|
Merged, thanks! |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [junegunn/fzf](https://github.com/junegunn/fzf) | patch | `v0.61.2` -> `v0.61.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>junegunn/fzf (junegunn/fzf)</summary> ### [`v0.61.3`](https://github.com/junegunn/fzf/releases/tag/v0.61.3): 0.61.3 [Compare Source](junegunn/fzf@v0.61.2...v0.61.3) - Reverted [#​4351](junegunn/fzf#4351) as it caused `tmux run-shell 'fzf --tmux'` to fail ([#​4559](https://github.com/junegunn/fzf/issues/4559) [#​4560](https://github.com/junegunn/fzf/issues/4560)) - More environment variables for child processes ([#​4356](junegunn/fzf#4356)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yNTcuOCIsInVwZGF0ZWRJblZlciI6IjM5LjI1Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
I was trying to create a complex command and needed some variables to restore the state of application, but I saw that I could not find some variables because they were not implemented!
Mainly the "FZF_POINTER" variable! I believe it is important that it is accessible! I exported the others to maintain consistency only.
Other thing: The variable 'FZF_LIST_LABEL' was already being exported, but not documented in the manpage!
Thanks.