Disable tmux popup when already running inside one #4351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junegunn
approved these changes
Apr 18, 2025
|
Thanks! |
|
Yesterday, I spent hours guessing which update in my system broke my beautiful popups in |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Apr 26, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [junegunn/fzf](https://github.com/junegunn/fzf) | patch | `v0.61.2` -> `v0.61.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>junegunn/fzf (junegunn/fzf)</summary> ### [`v0.61.3`](https://github.com/junegunn/fzf/releases/tag/v0.61.3): 0.61.3 [Compare Source](junegunn/fzf@v0.61.2...v0.61.3) - Reverted [#​4351](junegunn/fzf#4351) as it caused `tmux run-shell 'fzf --tmux'` to fail ([#​4559](https://github.com/junegunn/fzf/issues/4559) [#​4560](https://github.com/junegunn/fzf/issues/4560)) - More environment variables for child processes ([#​4356](junegunn/fzf#4356)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yNTcuOCIsInVwZGF0ZWRJblZlciI6IjM5LjI1Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmux popupdoesn't work and immediately returns instead when spawn inside one (tmux popup tmux popup echo fooresults in an empty popup). For that reason,fzf --tmuxdoesn't work when executed inside atmux popup, for example:FZF_DEFAULT_OPTS=--tmux tmux popup 'find . | fzf'And executing
fzf --tmuxinsidefzf --tmux(asforgitdoes, which was how I ran into this issue) also doesn't work, for example:A popup can be detected by the absence of the
TMUX_PANEenvironment variable, so we can simply disable the--tmuxmode when it is absent. And it also must be excluded for the exports inrunProxy()so that the popup can also be detected properly by child processes.