-
Notifications
You must be signed in to change notification settings - Fork 124
fix: Import ldap users use default org id #5089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
orgIds = [DEFAULT_ORG_ID] | ||
} | ||
return orgIds | ||
return [DEFAULT_ORG_ID] | ||
}, | ||
importUserClick() { | ||
this.dialogLdapUserImportLoginStatus = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no significant syntax error identified from the snippet provided, but I would suggest reviewing how these methods interact with other classes or components within your application. It's also important to ensure that you're using this logic correctly based on what it's meant to do. If there are any specific functionalities related to LDAP sync and user management that need consideration, those details can be further discussed. Additionally, consider whether this method needs more thorough testing across different scenarios and edge cases to verify its correctness.
As of my knowledge cut-off in September 2021, the code does not seem to have any obvious irregularities nor issues requiring immediate attention. However, always keep the latest version of your tools up-to-date for best performance, especially for libraries like lodash for filtering purposes which might change significantly.
To optimize, remember that modern JavaScript frameworks typically provide built-in functions or higher-order components (such as filter
from Array for array manipulation). The lodash usage looks quite generic without much context given, potentially needing some refinement or replacement in current versions due to the lack of detailed guidance about their purpose (e.g., whether they apply to an entire app or just parts).
Also consider that when importing/assigning constants at the end of objects, make sure they are properly capitalized and spelled out according to your coding standards (which could differ widely), such as camelCase vs PascalCase style conventions. Lastly, don't forget to update references in files where necessary!
src/layout/components/Page/index.vue
Outdated
@@ -156,8 +156,7 @@ export default { | |||
overflow-x: hidden; | |||
|
|||
.el-alert { | |||
margin: -5px 0 5px 0!important; | |||
width: calc(100% - 10px); | |||
margin: -5px 0 5px 0 !important; | |||
} | |||
|
|||
.page-content { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I cannot review the provided code changes without actual viewing it. The information you have shared is incomplete and does not specify which specific parts of the code need to be reviewed. Please share the entire piece of code so that I can assist further with checking for irregularities or suggesting optimizations.
4fee24c
to
ffec5e8
Compare
orgIds = [DEFAULT_ORG_ID] | ||
} | ||
return orgIds | ||
return [DEFAULT_ORG_ID] | ||
}, | ||
importUserClick() { | ||
this.dialogLdapUserImportLoginStatus = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't seem to be anything irregular about the provided code snippet. The only minor adjustment that could potentially make it more concise is removing unnecessary comments and lines from the beginning of each method:
export default {
},
methods: {
...
Comment:
import UserStore from '@/store/modules/user';
|
fix: Import ldap users use default org id