Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Jul 15, 2025

Fixed: Fix the issue of direct connection organizations not synchronizing.

@@ -135,7 +135,7 @@ export class TableColumnsGenerator {
prop: 'actions',
label: i18n.t('Actions'),
align: 'center',
width: this.dynamicActionWidth(),
width: '120px',
formatter: ActionsFormatter,
fixed: 'right',
formatterArgs: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code does not contain any known regular errors but it seems to be very outdated, as the use of Vue.js and dynamic action widths has been replaced with modern practices like Composable functions. Also, using console.log is an obsolete practice due to increased performance concerns.

Potential optimizations would involve replacing console.log with higher performane options in development mode and/or logging to file when developing instead of debugging on-the-fly inside components where you're working. Using Vue.debug() can give you access at runtime to debug objects in your component code if required.

For more specific questions about a single part of the code snippet, please provide the actual relevant code lines for analysis.

@fit2bot fit2bot requested a review from a team July 15, 2025 12:23
@ZhaoJiSen ZhaoJiSen merged commit 80e42d1 into dev Jul 15, 2025
3 of 4 checks passed
@@ -60,6 +60,7 @@ export default {
asset=${assetId}
&account=${row.id}
&protocol=${protocol}
&org_id=${this.$store.getters.currentOrg.id}
`.replace(/\s+/g, '')
},
asset: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None. The provided code seems to be consistent and functional without any issues or irregularities.

Suggestions:

  • Ensure that the protocol value is only setted when the account data exists (using a ternary operator would make it clearer).
     protocol?: string = row?.asset_type && `${RowAssetData.PATH[$[row.asset_type]]}` || RowAssetData.SWIFT_ID
    
  * Consider refactoring the conditionals to use an expression statement within a conditional block to simplify readability.
    ```
            return {
               asset: ${assetId},
                 &account: row.id, 
               &organization_id: this.$store.getters.currentOrg.id,

@ZhaoJiSen ZhaoJiSen deleted the pr@dev@fix_direct_connect branch July 15, 2025 12:23
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants