Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Jul 15, 2025

fix: el-alert width css

@fit2bot fit2bot requested a review from a team July 15, 2025 09:10
@@ -156,8 +156,7 @@ export default {
overflow-x: hidden;

.el-alert {
margin: -5px 0 5px 0!important;
width: calc(100% - 10px);
margin: -5px 0 5px 0 !important;
}

.page-content {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no major syntax errors or obvious deviations from the standard template code. The most noticeable difference is:

The original version uses !important to override the styles. You might consider removing it since this can lead to less predictable behavior across devices and different versions of browsers.

However, if you're not using any vendor-specific prefixes (e.g., -webkit-, -moz-) already then that doesn't seem critical right now based on the knowledge cutoff provided - but it's good practice to use them consistently!

Optimization suggestion: Ensure padding values adhere exactly to CSS grid alignment principles rather than being rounded; otherwise elements inside an element with grid-template-columns:auto * 300px; like .page-content could become unevenly spaced. Consider adding a media query when screen size > 640px to adjust the layout accordingly.

Copy link

@w940853815 w940853815 merged commit 5efe66b into dev Jul 15, 2025
6 checks passed
@w940853815 w940853815 deleted the pr@dev@fix_el_alert_css branch July 15, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants