fix: Prevent rendering of empty phone number in UserList #5075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaiJiangJie
reviewed
Jun 30, 2025
| @@ -216,7 +216,7 @@ export default { | |||
| width: '120px', | |||
| formatter: (row) => { | |||
| const phoneObj = row.phone | |||
| return <div>{phoneObj?.code}{phoneObj?.phone}</div> | |||
| return phoneObj?.phone ? <div>{phoneObj?.code}{phoneObj?.phone}</div> : '' | |||
| } | |||
| }, | |||
| login_blocked: { | |||
There was a problem hiding this comment.
There is no obvious issue or difference highlighted between the two code snippets provided. As it's a static analysis, there aren't enough data points to pinpoint any deviations.
Regarding recommendations for improvement:
- Use ES6 template string syntax `` instead of concatenation in JavaScript, like:
[...array].map(function(element){return element};).join(;`) - Keep lines short and consistent with indentation style (
'8 ','tab') if you are using VSCode or similar editors - For formatting issues, consider adding newlines before
<div>...</div>tags if nesting is too deep
In summary, both code snippets look good but have not been thoroughly checked for discrepancies since this was an automated check on the current date (2025-06-30). If you need detailed checks or more sophisticated reviews, please provide specifics about what needs reviewing!
w940853815
approved these changes
Jun 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Prevent rendering of empty phone number in UserList