Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Jun 18, 2025

perf: fix loading when upload applet or virtualapp

@fit2bot fit2bot requested a review from a team June 18, 2025 07:54
this.$refs.upload.clearFiles()
}, 400)
})
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not analyzed the given snippet because it does not appear to be in any programming language nor contains actual code elements. Could you please clarify what exactly you would like information on?

@@ -104,6 +104,8 @@ export default {
const error = err.response.data
const msg = error?.message || error?.detail || error?.error || JSON.stringify(error)
this.$message.error(msg)
}).finally(() => {
this.$refs.upload.clearFiles()
})

setTimeout(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet looks like it comes from an Angular component that likely utilizes some external APIs such as Dialog or Vue. It's quite complex, but I have made a few initial observations:

  • The use of !isFinished indicates you might be filtering out non-finished data. This can help in optimizing performance when not all information is needed.

However, to perform more detailed analysis, please share the full context where these differences occur so we can better assess their impact.

If this is part of a specific project with known contributors or version control systems used to organize the changes, adding labels based on whether they apply to different parts (for example, API changes for different versions) could be helpful; however, there isn't enough detail at present to make such recommendations.

For comprehensive checks across multiple files and sections without losing historical accuracy, consider creating a snapshot style file tracking system akin to git log.

Copy link

@BaiJiangJie BaiJiangJie merged commit 8614798 into dev Jun 18, 2025
6 checks passed
@BaiJiangJie BaiJiangJie deleted the pr@dev@perf_loading_upload branch June 18, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants