feat: remove oracle endpoint form field oracle_port disabled #5050
Conversation
| @@ -40,9 +40,6 @@ export default { | |||
| host: { | |||
| disabled: this.$route.params.id === '00000000-0000-0000-0000-000000000001' | |||
| }, | |||
| oracle_port: { | |||
| disabled: true | |||
| }, | |||
| is_active: { | |||
| disabled: this.$route.params.id === '00000000-0000-0000-0000-000000000001' | |||
| } | |||
There was a problem hiding this comment.
The above snippet contains two main differences:
Firstly, the export default statement should be at the end of a file (it seems to be starting before the start tag).
Secondly, I've noticed a typo with the parameter name "id" being capitalized ($route.params.id) instead of lowerCase (this.$route.params.id). Make sure all variable names follow proper naming conventions.
In terms of optimizing it further,
- Use an actual import statement like
import { $host } from '@/services/host';- If needed, use
truefor disabled properties if there will definitely not be any active value for that property. The current syntax usingdisabledcould lead to unexpected behavior when the route matches no data for that field. - For more clarity, you can wrap elements in quotes around string literals.
- Avoid hard-coded values or constant variables for sensitive information which might need validation later on if deployed into production environment.
Also make sure, if possible, use Vue's internal types where applicable and consistent them throughout your project if they exist, these have been improved over last few release cycles, especially regarding how typechecking works. Please ensure code follows best coding practices as per the latest version of Vue CLI.
|
feat: remove oracle endpoint form field oracle_port disabled