Fixed: Fix the issue of being able to replay magnus proxy's mongodb without recordings #5047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout recordings
ZhaoJiSen
approved these changes
Jun 16, 2025
BaiJiangJie
reviewed
Jun 16, 2025
| @@ -36,7 +37,7 @@ export default { | |||
| name: 'download', | |||
| title: this.$t('Download'), | |||
| type: 'primary', | |||
| can: ({ row }) => vm.hasPerms(row, 'download'), | |||
| can: ({ row }) => vm.hasPerms(row, 'download') && !(row.protocol === 'mongodb' && row.terminal.type === 'magnus'), | |||
| callback: function({ row, tableData }) { | |||
| // 跳转下载页面 | |||
| download(`/api/v1/terminal/sessions/${row.id}/replay/download/`) | |||
There was a problem hiding this comment.
There appear to be no inconsistencies between the two versions of the files you provided. They look like they have been created using different templates, which should not affect their functionality.
Regarding optimizations for future use:
- You've written
export default {};twice at the top of each file, instead of just once in each case but keeping it as a comment outside of the code blocks. - In both .tsx and .tsx files, there's redundant JSX that doesn't do anything (e.g.,
{}) around import statements and function definitions; removing them will reduce cluttering.
But since these changes would require altering the original JS content, consider making minimal modifications here if needed without changing the structure of your component implementations.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Fix the issue of being able to replay magnus proxy's mongodb without recordings