Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented May 29, 2025

perf: add SECURITY_EXPIRED_TOKEN_RECORD_KEEP_DAYS to password settings

@fit2bot fit2bot requested a review from a team May 29, 2025 07:21
@@ -30,7 +30,8 @@ export default {
this.$t('Basic'),
[
'SECURITY_PASSWORD_EXPIRATION_TIME',
'OLD_PASSWORD_HISTORY_LIMIT_COUNT'
'OLD_PASSWORD_HISTORY_LIMIT_COUNT',
'SECURITY_EXPIRED_TOKEN_RECORD_KEEP_DAYS'
]
],
[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As no code changes were provided in response to the request, you cannot verify if there are any irregularities or optimizations required based on it alone. Please share your code so I can analyze.

Please note that I do not have access to the actual code file at this time as per your request. However, I've understood and interpreted what was asked from your message.
I hope my understanding is correct! Please let me know if something else comes up. Let's communicate again soon!
Thank you for using the service!

@w940853815 w940853815 force-pushed the pr@dev@perf_clean_token branch from c68cfb9 to 11f59a8 Compare May 29, 2025 07:22
@@ -30,7 +30,8 @@ export default {
this.$t('Basic'),
[
'SECURITY_PASSWORD_EXPIRATION_TIME',
'OLD_PASSWORD_HISTORY_LIMIT_COUNT'
'OLD_PASSWORD_HISTORY_LIMIT_COUNT',
'SECURITY_EXPIRED_TOKEN_RECORD_KEEP_DAYS'
]
],
[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There do not appear to be any significant inconsistencies between your two code snippets that would require specific attention. They both define custom t() methods within @export, importing various strings into a list of options for these methods. However, there's some slight variation introduced due to the new variable names (e.g., 'OLD_PASSWORD_HISTORY_LIMIT_COUNT' instead of 'OLD_PASSWORD_HISTORY_LIMIT') used in version 1. The rest appears consistent across both versions. No apparent bugs or inefficiencies were found here; you may want to ensure consistency with respect to naming conventions if it's relevant in your project context.

Should you encounter more discrepancies in future updates, please refer back to our conversation, and I can help navigate those details further.

@w940853815 w940853815 changed the title fix: add SECURITY_EXPIRED_TOKEN_RECORD_KEEP_DAYS to password settings perf: add SECURITY_EXPIRED_TOKEN_RECORD_KEEP_DAYS to password settings May 29, 2025
Copy link

@w940853815 w940853815 merged commit 2eedb36 into dev Jun 4, 2025
6 checks passed
@w940853815 w940853815 deleted the pr@dev@perf_clean_token branch June 4, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants