-
Notifications
You must be signed in to change notification settings - Fork 124
perf: Applets drop account template #5007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -98,6 +99,7 @@ export default { | |||
}, | |||
data() { | |||
const accounts = this.value || [] | |||
|
|||
return { | |||
accounts: accounts, | |||
drawerRefName: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The given code is from a React application (specifically an el-table component). The main tasks that can be performed here include:
-
Checking for differences: It appears you haven't provided the specific difference(s) you're checking in terms of changes. Could you please share these details? Generally speaking, differences could range from variable names to function/property name usage or implementation.
-
Potential issues / optimizations:
- Ensure consistency throughout your components. Make sure all elements have consistent formatting and naming convention within each file.
- Review functions and logic where possible; consider if there are more efficient ways to achieve similar outcomes. For example, consider using
Array.some()
instead of direct.includes()
when iterating over array items. - In cases where state management needs are high, discuss the use of tools like Redux vs local variables (with hooks), depending on how critical state updates are and resource usage.
I would recommend reviewing and updating only those areas needing improvement based on thorough coding practices and performance analysis as necessary.
Regarding the specifics of your request about "Check for differences", I assume you may want to verify that no mistakes have been made due to syntax errors, loose definitions or improper execution order between different stages or scripts of your codebase. If you can provide more context regarding the exact nature of discrepancies or what exactly you aim to validate through this test, I'd be able to assist better with tailored advice based on the situation.
@@ -64,6 +64,7 @@ export default { | |||
{ | |||
name: this.$t('AccountTemplate'), | |||
title: this.$t('AccountTemplate'), | |||
has: this.$hasLicense() || this.$route.name !== 'Applets', | |||
can: () => this.$hasPerm('accounts.view_accounttemplate') && !this.$store.getters.currentOrgIsRoot, | |||
callback: () => { | |||
this.templateDialogVisible = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is fine, nothing to suggest for this question
|
perf: Applets drop account template