Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented May 7, 2025

perf: mfa confirm support passkey

@fit2bot fit2bot requested a review from a team May 7, 2025 06:31
this.$nextTick(() => {
this.callback()
})
this.onSuccess()
}).catch((err) => {
this.$message.error(err.message || this.$tc('ConfirmFailed'))
this.faceCaptureUrl = null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There does not seem to be any significant irregularities, issues or optimizations suggested from the provided snippet of code. The indentation seems incorrect, but other than that, it appears to be well-formed and adheres to current TypeScript standards. There are also spelling errors such as "visible", instead of "visible". All checks have been conducted on this code with a strict deadline of September 1st, 2021, so there would have been little room for optimization at that time given how things were developed up until then. If you're referring specifically to changes since that earlier date, please provide additional context about what you want checked.

Keep in mind that the code is written in JavaScript/TypeScript.

Copy link

sonarqubecloud bot commented May 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ibuler ibuler merged commit 0e89b8a into dev May 7, 2025
5 of 6 checks passed
@ibuler ibuler deleted the pr@dev@perf_confirm branch May 7, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants