Fixed: Fix the issue with direct connection for SFTP. #4979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhaoJiSen
approved these changes
Apr 27, 2025
baijiangjie
reviewed
Apr 27, 2025
| @@ -115,8 +115,7 @@ export default { | |||
| const url = this.formatterArgs.assetUrl.replace('{id}', assetId) | |||
| const res = await this.$axios.get(url) | |||
|
|
|||
| // TODO 暂时将 sftp 隐藏 | |||
| this.protocols = res.protocols.filter(protocol => (protocol.name !== 'sftp') && (protocol.name !== 'winrm')) || [] | |||
| this.protocols = res.protocols.filter(protocol => (protocol.name !== 'winrm')) || [] | |||
| } catch (e) { | |||
| throw new Error(`Error getting protocols: ${e}`) | |||
| } | |||
There was a problem hiding this comment.
The first difference between two versions of the code is that we now have "export" keyword instead of the previous import statement which makes it difficult to use other files.
For potential issues:
It seems like there might be some errors in the JavaScript syntax used here but not clearly mentioned. There should probably no need to add @ before the line number because you already specified it as global level scope.
Also, please make sure these changes do not interfere with existing dependencies/usage in any way!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Fix the issue with direct connection for SFTP.