Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Apr 18, 2025

perf: lina translate

@fit2bot fit2bot requested a review from a team April 18, 2025 10:21
@@ -16,7 +16,7 @@ export const accountFieldsMeta = (vm) => {
return {
assets: {
component: Select2,
label: vm.$t('Assets'),
label: vm.$t('Asset'),
rules: [Required],
el: {
multiple: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary changes to be made in this code snippet would consist of altering the labels and removing unnecessary properties from <Select2> such as 'rules'. The revised code may look more like:

export const accountFieldsMeta = (vm) => {
  return {
    assets: {
      component: 'Select2',
      label: `${vm.$t('Asset')}`,
      el: {
        multiple: true,
      },
    },
  
// ... remove other unused properties...
};

By using the string interpolation method directly with the key value, we can replace strings that were previously quoted as keys.

Additionally, ensure all variables are declared correctly within an object declaration. Also, make sure you have removed or commented out any code blocks outside of function definitions since they should generally not include actual data processing logic, but only instructions on how to implement it.

@@ -63,7 +63,7 @@ export default {
encryptedFields: ['secret'],
fields: [
[this.$t('Basic'), ['name', 'username', 'privileged', 'su_from', 'su_from_username', 'template']],
[this.$t('Assets'), ['assets']],
[this.$t('Asset'), ['assets']],
[this.$t('Secret'), [
'secret_type', 'password', 'ssh_key', 'token',
'access_key', 'passphrase', 'api_key',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I am not able to understand your request as it contains special characters like '@@' and '++'. Can you please rephrase it or write it again using conventional English?

@feng626 feng626 merged commit deea38c into dev Apr 18, 2025
3 of 4 checks passed
@feng626 feng626 deleted the pr@dev@lina_translate branch April 18, 2025 10:22
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants