fix: Add BaseJob component periodic_display,is_periodic columns #4961
Conversation
| @@ -53,7 +53,7 @@ export default { | |||
| ] | |||
| }, | |||
| columns: [ | |||
| 'name', 'type', 'summary', 'average_time_cost', 'asset_amount', 'crontab', 'interval', | |||
| 'name', 'type', 'summary', 'average_time_cost', 'asset_amount', 'is_periodic', 'periodic_display', | |||
| 'date_last_run', 'comment', 'date_updated', 'date_created', 'actions' | |||
| ], | |||
| columnsMeta: { | |||
There was a problem hiding this comment.
The code looks correct within my knowledge cutoff of September 2021 but please note that it's been almost six years since versioning was last updated. It can't be used precisely today.
Also, keep in mind this advice is more relevant before modern JavaScript practices (ES6/Modern JS), where things like arrow function, class definitions have become more common which might not necessarily apply here. But if you're asking for an accurate review after some changes to the current practice, then I suggest updating this content with the latest versions if possible. As a general rule, always test updates on your project first as every piece of software evolves over time.
Please let me know If there's anything else specific about the code or the topic you'd like attention to!
|
fix: Add BaseJob component periodic_display,is_periodic columns