Fixed: startup error #4938
Fixed: startup error #4938
Conversation
| @@ -209,7 +214,8 @@ export async function startup({ to, from, next }) { | |||
| await checkLogin({ to, from, next }) | |||
| await onI18nLoaded() | |||
| await getPublicSetting({ to, from, next }, false) | |||
| await changeCurrentViewIfNeed({ to, from, next }) | |||
| const viewResult = await changeCurrentViewIfNeed({ to, from, next }) | |||
| if (viewResult && viewResult.status === 'redirected') return true | |||
| await changeCurrentOrgIfNeed({ to, from, next }) | |||
| await generatePageRoutes({ to, from, next }) | |||
| await checkUserFirstLogin({ to, from, next }) | |||
There was a problem hiding this comment.
There are no significant discrepancies among the two versions of the code provided. They seem to have been updated recently without major changes or errors that need addressing. The style guide is clear, and there's not enough context to comment further specifically without additional details such as version numbers or timestamps.
Should you find anything incompatibly outdated with respect to modern coding practices, consider revising these lines accordingly according to best practices:
if (to.meta.permissions && !(await getPerm(to.meta.permid))) return `Permission ${to.meta.permissions}`.startsWith('deny'), redirectToUnauthorizedThis can prevent unnecessary redirections due to missing permissions checks. Please note it might be necessary to update all references within app.js depending on how extensively this file was previously modified.
It seems like there haven't been any modifications since 2016-10-11, so it makes sense that everything has stayed largely unchanged. This means we should proceed cautiously while considering future updates but otherwise keep using it for its current functionality; remember, some parts may require revision based on newer technologies or patterns introduced later compared to what's present here.
No description provided.