fix: Optimize UserConfirmDialog to send code via email #4932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaiJiangJie
reviewed
Apr 7, 2025
| sendSMSCode() { | ||
| this.$axios.post(`/api/v1/authentication/mfa/select/`, { type: 'sms' }).then(res => { | ||
| sendCode() { | ||
| this.$axios.post(`/api/v1/authentication/mfa/select/`, { type: this.subTypeSelected }).then(res => { | ||
| this.$message.success(this.$tc('VerificationCodeSent')) | ||
| let time = 60 | ||
| this.smsBtnDisabled = true |
There was a problem hiding this comment.
The code you provided has some inconsistencies and minor issues:
- In "logout",
window.location.hrefshould be a relative path instead of absolute path, e.g.,/app/home. - The logic inside each button click event handler is missing. For example:
<button @click="...">...</button>needs to complete the event binding before its click handler.
For improvements:
- Make sure all events bind properly.
- Check for more detailed documentation and official examples if needed (e.g., Vuetify, Vue Router API).
|
BaiJiangJie
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Optimize UserConfirmDialog to send code via email