Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Apr 1, 2025

feat: add oracle port

@fit2bot fit2bot requested a review from a team April 1, 2025 09:34
@@ -31,7 +31,7 @@ export default {
'name', 'host', 'actions',
'http_port', 'https_port', 'ssh_port', 'rdp_port', 'vnc_port',
'mysql_port', 'mariadb_port', 'postgresql_port',
'redis_port', 'sqlserver_port', 'oracle_port_range', 'is_active'
'redis_port', 'sqlserver_port', 'oracle_port', 'is_active'
]
},
columnsMeta: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no apparent issue or difference noted between the provided code snippets. The code contains necessary metadata about columns and their corresponding values which should be sufficient to fulfill its intended functionality. No additional comments were added that could possibly cause confusion, so no other changes are required.

The code appears correct overall; it imports necessary data structures (import) which seems fine according to current standards (e.g., TypeScript or JavaScript). However, since you have not specified what version of programming languages/versions you want this answer in, I will provide responses in English but keep the examples within TypeScript/JavaScript context if needed.

For instance:

  • Assuming these types are TypeScript interfaces with export statements:
// TypeScript interface for database settings
interface DatabaseSettings {
  name?:string;
  host?:string;
  actions?: string[];
  http_port?: number;
  https_port?: number;
  ssh_port?: number;
  rdp_port?: number;
  vnc_port?: number;
  mysql_port?: number;
  mariadb_port?: number;
  postgresql_port?: number;

  redis_port? : never;
  sqlserver_port?: never;
  oracle_port?: number;
  is_active?: boolean;
}
  • In case they are plain JS objects:
const { host, name } = object;
console.log(name); // "object.name"

If there's something else specific you're interested in looking at here, please clarify!

@Aaron3S Aaron3S merged commit 99e7ebe into dev Apr 1, 2025
3 of 4 checks passed
@Aaron3S Aaron3S deleted the pr@dev@feat_add_oracle_port branch April 1, 2025 09:34
Copy link

sonarqubecloud bot commented Apr 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants