Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Mar 19, 2025

perf: Asset domain

@fit2bot fit2bot requested a review from a team March 19, 2025 03:26
@@ -74,7 +75,7 @@ export default {
cleanFormValue(values) {
const data = []
values.assets.forEach(item => {
const d = { id: item, domain: this.$route.params.id }
const d = { id: item, domain: vm.object.id }
data.push(d)
})
return data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any specific differences within your provided code snippet that could be considered irregularities, potential issues, or areas needing optimization. Your code seems to be working fine based on its current state and structure.

For instance, you're using a Vue component framework which allows it to handle asynchronous functions easily when dealing with API calls (getUrl). If needed, the cleanFormValue function can make slight adjustments if it needs more sophisticated behavior (e.g., handling error conditions of getting asset IDs) considering JavaScript ES6 syntax changes since 2015:

export const cleanFormValue = async(values) => {
// ... rest of your function here including any necessary imports etc.
}

If these are some requirements I should know about so we can further explore this issue together?

@feng626 feng626 merged commit 2f8480e into dev Mar 19, 2025
3 of 4 checks passed
@feng626 feng626 deleted the pr@dev@asset_domain branch March 19, 2025 03:26
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants