Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Mar 14, 2025

Fixed: Dashboard Filter

@fit2bot fit2bot requested a review from a team March 14, 2025 08:46
@@ -162,7 +162,7 @@ export default {

if (!payload) return

const queryParams = `?risk=${payload}`
const queryParams = `&risk=${payload}`

if (queryParams) {
this.tableConfig.url += queryParams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are no changes between the exported function definitions for the two code snippets in question. The code is self-contained in both cases, and they're doing essentially what they're supposed to without including additional logic that wouldn't change depending on the environment (like HTTP authentication). However, I'm not aware of any common best practices regarding this exact piece of code. You might want to ask it out in more specific contexts about how exactly you'd use something like this.

@ZhaoJiSen ZhaoJiSen merged commit 3cef144 into dev Mar 14, 2025
3 of 4 checks passed
@ZhaoJiSen ZhaoJiSen deleted the pr@dev@fix_dashboard_filter branch March 14, 2025 08:46
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants