Skip to content

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Mar 13, 2025

Fixed: Domain Title

@fit2bot fit2bot requested a review from a team March 13, 2025 10:23
@@ -6,6 +6,7 @@
:detail-drawer="detailDrawer"
:header-actions="headerActions"
:table-config="tableConfig"
:resource="$tc('Gateway')"
/>
<GatewayDialog
:cell="cell"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an inconsistency between the "gate" and the $tC("Gateway") string used in the code snippet. The correct version of the GatewayDialog should be:

    "@@ -6,7 +6,8 @@
      :detail-drawer="detailDrawer"
      :header-actions="headerActions"
      :table-config="tableConfig"

      :"resource={$t('Gateway')}"

This way, it will use the localizable resource named "Gateway". Other than this small typo, there doesn't appear to be any major discrepancies or problems with the syntax.

Note:

  1. I updated the text formatting considering that you were writing in English.
  2. No significant improvements needed as there weren’t any known issues found while reviewing the given codes snippet without any context about how they're supposed to work together.

@ZhaoJiSen ZhaoJiSen merged commit 420145a into dev Mar 13, 2025
3 of 4 checks passed
@ZhaoJiSen ZhaoJiSen deleted the pr@dev@fix_domain_title branch March 13, 2025 10:23
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants