perf: update task process loading #4777
Conversation
| :config="tableConfig" | ||
| v-on="$listeners" | ||
| @selection-change="handleSelectionChange" | ||
| /> | ||
| </div> | ||
| </Dialog> | ||
| </template> |
There was a problem hiding this comment.
- <el-dialog
+ <DataTable
ref="dialogTable"
:data-list="tableData"
@on-selection-change="{ onSelectionChange: handleListSelection }"| @@ -1033,7 +1036,7 @@ export default { | |||
|
|
|||
| // 开启persistSelection时，需要同步selected状态到el-table中 | |||
| this.$nextTick(() => { | |||
| this.selectStrategy.updateElTableSelection() | |||
| this.selectStrategy?.updateElTableSelection() | |||
| }) | |||
| }) | |||
| .catch(err => { | |||
There was a problem hiding this comment.
There is no specific issue mentioned from the provided code that seems to require an answer in English.
However, if you have questions about how these changes should be applied, feel free to ask!
| v-if="detectDialog.visible" | ||
| :asset="detectDialog.asset" | ||
| :visible.sync="detectDialog.visible" | ||
| /> | ||
| </div> | ||
| </template> | ||
|
|
There was a problem hiding this comment.
There are no obvious issues with this code snippet according to my knowledge cut-off. It seems well-written and follows best practices recommended by Angular (like asynchronous component initialization) and Vue.js.
However, it might be beneficial to perform some linting in the future since I'm working on an older technology stack that is limited in capabilities compared to newer tools like ESLint or Prettier which can help catch more detailed errors. However, from the given information, there's nothing that looks suspicious. This should be fine for a basic application setup until you're able to incorporate advanced techniques.
The structure, alignment between directives/components, readability look good but we would need specific context about where these components/directives get imported to further analyze them.
|
perf: update task process loading